Supporting Multiple TestProperty with the same key value.#328
Supporting Multiple TestProperty with the same key value.#328navin22 merged 4 commits intomicrosoft:masterfrom
Conversation
navin22
commented
Jan 9, 2017
navin22
commented
- Changed the way of deserialization using custom TraitObject.
- Added UnitTests for the same.
- Changed the way of deserialization using custom TraitObject. - Added UnitTests for the same.
|
|
| // Converting Json data to array of KeyValuePairs with duplicate keys. | ||
| var serializer = new System.Runtime.Serialization.Json.DataContractJsonSerializer(typeof(List<TraitObject>)); | ||
|
|
||
| var listOfTratiObjects = serializer.ReadObject(stream) as List<TraitObject>; |
There was a problem hiding this comment.
s/listOfTratiObjects/listOfTraitObjects
| var listOfTratiObjects = serializer.ReadObject(stream) as List<TraitObject>; | ||
| listOfTratiObjects.ForEach(o=>listOfKvps.Add(new KeyValuePair<string, string>(o.Key, o.Value))); | ||
|
|
||
| return listOfKvps?.ToArray(); |
There was a problem hiding this comment.
Why is null check required for listOfKvps?
| var serializer = new System.Runtime.Serialization.Json.DataContractJsonSerializer(typeof(List<TraitObject>)); | ||
|
|
||
| var listOfTratiObjects = serializer.ReadObject(stream) as List<TraitObject>; | ||
| listOfTratiObjects.ForEach(o=>listOfKvps.Add(new KeyValuePair<string, string>(o.Key, o.Value))); |
There was a problem hiding this comment.
Extra allocation and insertion into listOfKvps may not be required. Is something like below possible?
listOfTratiObjects.Select(t => new KeyValuePair<string, string>(t.Key, t.Value)).ToArray()
There was a problem hiding this comment.
Yes possible. Changed it.
codito
left a comment
codito
left a comment
There was a problem hiding this comment.
Approach looks fine. Request few changes.
|
#239 issue is resolved by this PR. |
2 participants
